search

docker-archive / communitytools-image2docker-win

305 stars 78 forks source link

Convert-WindowsImage is the name of another tool for ISO -> VHD conversion #1

Closed PatrickLang closed 8 years ago

PatrickLang commented 8 years ago

Convert-WindowsImage is already well known commandlet used to convert Windows ISO images to VHD/VHDX: https://gallery.technet.microsoft.com/scriptcenter/Convert-WindowsImageps1-0fe23a8f

All commandlets are supposed to have a verb-noun format, so I think something like Create-Dockerfile or ConvertTo-Dockerfile would make more sense to avoid confusion with the existing Convert-WindowsImage

ManoMarks commented 8 years ago

@pcgeek86 What do you think?

pcgeek86 commented 8 years ago

@PatrickLang @ManoMarks The Convert-WindowsImage PowerShell script that is referred to isn't in the core PowerShell experience. It's a third-party script hosted on a community repository. We can still go ahead and rename the command to ConvertTo-Dockerfile. That seems more appropriate.

sixeyed commented 8 years ago

@pcgeek86 +1 - ConvertTo is in the approved list

pcgeek86 commented 8 years ago

Fixed in this commit

https://github.com/docker/communitytools-image2docker-win/commit/7acd572349d0bdd160d5d6fd32c1211a3d6ca1fa