search

docker-archive / communitytools-image2docker-win

304 stars 78 forks source link

Consolidate Windows Server Feature discovery into a single artifact #3

Closed sixeyed closed 7 years ago

sixeyed commented 8 years ago

@pcgeek86 is there a reason for having multiple Discover/Generate steps, each for an explicit Windows Feature? Could we have a generic step that discovers all installed features with Get-WindowsFeature ... | Where Installed and a generic generate which does Add-WindowsFeature for all the installed features?

I think those commands are also available for 2008R2 so potentially gives the tool a wider reach.

pcgeek86 commented 8 years ago

@sixeyed Good question. There are certainly multiple ways of approaching this. However, certain Windows Features actually have deeper configuration that goes into them.

Right now, I see a couple of different options available to move forward:

What do you think?

sixeyed commented 8 years ago

I would incline to do both. Option 1 gives a lot of value quickly with a horizontal sweep. Then we can add more depth incrementally with new features - IIS website setup, MSMQ queues etc, which we could prioritise separately.

Also I think listing all the features in one hit in the Dockerfile puts users in a good place to trim out anything they're not using.

On 14 Sep 2016 17:33, "Trevor Sullivan" notifications@github.com wrote:

@sixeyed https://github.com/sixeyed Good question. There are certainly multiple ways of approaching this. However, certain Windows Features actually have deeper configuration that goes into them.

Right now, I see a couple of different options available to move forward:

  • Option 1: Generalize all Windows Server Features as a single artifact
  • Option 2: Keep Windows Server Features as separate artifacts, and include deeper inspection of each Windows Server Feature in its corresponding artifact.

What do you think?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/docker/communitytools-image2docker-win/issues/3#issuecomment-247073569, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJm5fQ1XcaN0DMSjggmEVvOOVzjAVOQks5qqCHxgaJpZM4J8ffD .