search

docker-archive / communitytools-image2docker-win

305 stars 78 forks source link

SQL Server Artifact missing Fix #60

Open taylor-j-hawkins opened 7 years ago

taylor-j-hawkins commented 7 years ago

Resolves the issues with the SQLServer Artifact function. It's currently functional for cases with one SQLServer instance, but needs to be tested for cases where there are multiple SQLServer instances.

The reason for this pull request is documented in this issue:

"https://github.com/docker/communitytools-image2docker-win/issues/57"

WinniX commented 7 years ago

Hi @Marashni Do you know when this fix will be delivered?

sixeyed commented 7 years ago

Thanks for this @Marashni. @WinniX it's on-hold at the moment because recognizing SQL Server is only part of the workflow. The tool also needs to generate output from the source SQL database - and we're looking at options - e.g. should it extract the MDF file(s), or be more intelligent and extract just the schema.

taylor-j-hawkins commented 7 years ago

Hi @WinniX, this just fixes what the code was trying to do as it was written. However, as @sixeyed noted even with the fix to the code, it doesn't really do much except capture instance names. Functionality for pulling MDF's or schema has yet to be implemented.

qJake commented 7 years ago

This was advertised at Microsoft Ignite as working (being able to pull a live SQL Server database and convert it into a container image) during this session: https://myignite.microsoft.com/sessions/53257?source=sessions

Is that not true, does this functionality not exist yet?

taylor-j-hawkins commented 7 years ago

The last I was aware the code didn't really do anything. I submitted a pull request to fix the code as it was written to do what the code seemed to intend, which was to pull instance names out of a registry hive on your VM's .VHDX, and that's all it really does, last I knew.

That sounds like false advertising, but it's not the first I've seen regarding this tool. @Sixeyed probably knows more about the team's internal plans to implement the described functionality.