search

docker-archive / compose-cli

Easily run your Compose application to the cloud with compose-cli
Apache License 2.0
956 stars 253 forks source link

Go 1.18 #2174

Closed crazy-max closed 2 years ago

crazy-max commented 2 years ago

I plan to switch from shelling out to retrieve docker cli version by using the debug/buildinfo module in https://github.com/docker/compose-cli/pull/2151 that will give resp time <1ms but this package is available since Go 1.18: https://github.com/crazy-max/compose-cli/commit/ec18d50cfc97fb2a3163a0f0187e6e523a272b51

Also upgrading to Go 1.18 will slightly improve response time of the compose-cli itself:

CliVersionViaComposeCli/compose-cli-1.0.26-docker-20.10.17     70.8ms ± 0%
CliVersionViaComposeCli/compose-cli-go-1.18-docker-20.10.17    62.5ms ± 0%

cc @tonistiigi @glours @rumpl

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

crazy-max commented 2 years ago

argh some tests don't pass

--- FAIL: TestConvertSecrets (0.00s)
    --- FAIL: TestConvertSecrets/convert_colliding_default_targets (0.00s)
        secrets_test.go:150: assertion failed: mount paths "/run/secrets" and "/run/secrets/sub/folder" collide. A volume mount cannot include another one (string) != mount paths "/run/secrets" and "/run/secrets/sub/folder" collide. A volume mount cannot include another one. (string)
    --- FAIL: TestConvertSecrets/convert_colliding_absolute_targets (0.00s)
        secrets_test.go:174: assertion failed: mount paths "/home/user" and "/home/user/sub/folder" collide. A volume mount cannot include another one (string) != mount paths "/home/user" and "/home/user/sub/folder" collide. A volume mount cannot include another one. (string)