search

docker-archive / compose-cli

Easily run your Compose application to the cloud with compose-cli
Apache License 2.0
956 stars 253 forks source link

fix ecs docs reference to service.deployment #2184

Closed actualben closed 1 year ago

actualben commented 2 years ago

What I did Changes an entry in the docs/ecs-compose-features.md's "Compose fields mapping" table so that service.deploy.restart_policy is an x instead of a ✓ also removes a note from the service.restart item which is incorrect.

Related issue

fixes #2153 note: this pr was originally for bogus issue #2182

actualben commented 2 years ago

OK did the steps recommended by the DCO job docs to add my missing Signed-off-by on the commit: git rebase HEAD~1 --signoff followed by git push --force-with-lease origin fix-2182. Sorry about forgetting that.

laurazard commented 2 years ago

DCO is still failing unfortunately:

Expected "actualben [actualben@users.noreply.github.com](mailto:actualben@users.noreply.github.com)", but got "Ben Burke [actualben@users.noreply.github.com](mailto:actualben@users.noreply.github.com)".
actualben commented 2 years ago

how about now?

actualben commented 2 years ago

Would it be cool to change to this PR so it can close #2153? Apparently service.deploy.restart_policy is not supported in ecs either.

actualben commented 1 year ago

I didn't realize this PR was still open and deleted my fork. I think the change is still worth doing because issue 2153 is still open. I've created a replacement PR.