Closed actualben closed 1 year ago
OK did the steps recommended by the DCO job docs to add my missing Signed-off-by
on the commit: git rebase HEAD~1 --signoff
followed by git push --force-with-lease origin fix-2182
. Sorry about forgetting that.
DCO is still failing unfortunately:
Expected "actualben [actualben@users.noreply.github.com](mailto:actualben@users.noreply.github.com)", but got "Ben Burke [actualben@users.noreply.github.com](mailto:actualben@users.noreply.github.com)".
how about now?
Would it be cool to change to this PR so it can close #2153? Apparently service.deploy.restart_policy
is not supported in ecs either.
I didn't realize this PR was still open and deleted my fork. I think the change is still worth doing because issue 2153 is still open. I've created a replacement PR.
What I did Changes an entry in the
docs/ecs-compose-features.md
's "Compose fields mapping" table so thatservice.deploy.restart_policy
is anx
instead of a✓
also removes a note from theservice.restart
item which is incorrect.Related issue
fixes #2153 note: this pr was originally for bogus issue #2182