search

docker-archive / compose-cli

Easily run your Compose application to the cloud with compose-cli
Apache License 2.0
957 stars 255 forks source link

ECS: replace `github.com/sanathkr/go-yaml` with `gopkg.in/yaml.v3` #2228

Closed Juneezee closed 10 months ago

Juneezee commented 1 year ago

What I did

Currently we are using two YAML libraries:

  1. github.com/sanathkr/go-yaml v0.0.0-20170819195128-ed9d249f429b
  2. gopkg.in/yaml.v3 v3.0.1

This PR replaces github.com/sanathkr/go-yaml with gopkg.in/yaml.v3 for ECS. Doing this require updating the AWS CloudFormation package from v4.15.6 to v7.3.2.

The github.com/sanathkr/go-yaml was a fork and it was last updated in 2017. This library was added in https://github.com/docker/compose-cli/pull/544, and github.com/awslabs/goformation was also using the same library at that time. In AWS CloudFormation v7.2.0, they switched their YAML library to gopkg.in/yaml.v3 (https://github.com/awslabs/goformation/pull/535).

/test-ecs

(not mandatory) A picture of a cute animal, if possible in relation with what you did

image

Juneezee commented 1 year ago

Hi @milas , would you be kind enough to review this PR when you are free? Thanks :heart:

Juneezee commented 1 year ago

Hello @milas @StefanScherer @glours @ulyssessouza @nicksieger . I apologize for the explicit mention, but I wanted to follow up on this pull request I created some time ago.

I would be grateful if you could take some time to review the changes and provide me with your feedback. If there are any specific concerns or questions you have about the changes, I am more than willing to help address them.

Thank you for your time and consideration. I truly appreciate it. :heart:

Juneezee commented 10 months ago

This PR doesn't get any attention and this repository is retiring in November 2023.