anonymuse commented 8 years ago

Hi all,

In running through the Terraform demo, I'm having trouble when I set InfraKit to start watching the group:

In window01 I launch the terraform plugin:

$ infrakit/terraform --log 5 --dir $(pwd)/example/instance/terraform/aws-two-tier/
INFO[0000] Starting plugin
INFO[0000] Listening on: unix:///run/infrakit/plugins/instance-terraform.sock
DEBU[0000] terraform instance plugin. dir= /Users/jesse/Code/learn/dkr_infrakit/src/github.com/docker/infrakit/example/instance/terraform/aws-two-tier/
INFO[0000] listener protocol= unix addr= /run/infrakit/plugins/instance-terraform.sock err= <nil>

Once I try to set InfraKit to watch that group:

$ infrakit/cli group watch example/instance/terraform/aws-two-tier/group.json

I get a bunch of errors in the original window01 that makes it seems as though InfraKit can't find the Terraform executable.

INFO[0322] Acquired lock.  Applying
INFO[0322] Can't acquire lock.  Wait.
INFO[0322] Error: unknown command "apply" for "terraform"
  terraform=apply
INFO[0322] Run 'terraform --help' for usage.
            terraform=apply
INFO[0322] time="2016-10-06T14:01:31-04:00" level=error msg="unknown command \"apply\" for \"terraform\""
  terraform=apply
INFO[0322] Acquired lock.  Applying
INFO[0322] Can't acquire lock.  Wait.
INFO[0322] Error: unknown command "apply" for "terraform"
  terraform=apply
INFO[0322] Run 'terraform --help' for usage.
            terraform=apply
INFO[0322] time="2016-10-06T14:01:31-04:00" level=error msg="unknown command \"apply\" for \"terraform\""
  terraform=apply
INFO[0322] Acquired lock.  Applying
INFO[0322] Can't acquire lock.  Wait.
INFO[0322] Error: unknown command "apply" for "terraform"
  terraform=apply
INFO[0322] Run 'terraform --help' for usage.

Running terraform outside of the directory gives me this the expected program output:

$ terraform
usage: terraform [--version] [--help] <command> [args]

The available commands for execution are listed below.
The most common, useful commands are shown first, followed by
less common or more advanced commands. If you're just getting
started with Terraform, stick with the common commands. For the
other commands, please read the help and docs before usage.
...

While running it in the Go program directory starts the unix sock:

WOPR:infrakit jesse$ terraform
INFO[0000] Starting plugin
INFO[0000] Listening on: unix:///run/infrakit/plugins/instance-terraform.sock

Unsure of how to tell if InfraKit is calling Terraform appropriately, or how to set it. This is on Mac OSX Yosemite.

chungers commented 8 years ago

Before you run the plugin, the PATH may not be exported properly. The plugin does only terraform apply. There is a directory flag you should use to point to a directory like so: https://github.com/docker/infrakit/blob/master/example/instance/terraform/cattle_demo.md#2-start-the-plugins The directory is where your main.tf and .tfstate files live, etc.

Can you do a which terraform and terraform -h or show the version of Terraform? This plugin was built using the latest version, also developed on a Mac and tested on AWS.

anonymuse commented 8 years ago

Hi @chungers, thanks for the response.

I believe the problem lays here:

export PATH=$GOPATH/bin:$PATH

in the environment setup. Putting the GOPATH in from of the PATH, without controlling the path of Terraform, causes InfraKit to call the Terraform plugin instead of the Terraform software.

Depending on how InfraKit evolves, I'd consider solving this at the software, or the environment level. Do you plan to import the Terraform module at some point to avoid shelling out to the system?

The quickest and dirtiest solution that worked for me was to add the path to Terraform ahead of the GOPATH, which could be programmatically derived with a little command line magic (which + dirname, perhaps) in your setup script.

$ which terraform
/usr/local/bin/terraform
$ export PATH=/usr/local/bin:$GOPATH/bin:$PATH

If you thought this was the appropriate direction for the fix (as opposed to importing TF, or another solution, I could suggest an export that should work for everyone.

linsun commented 8 years ago

I ran into this too today. For me, I had my terraform from harshicorp installed in my go path. Then the terraform binary from infrakit overwrote the terraform binary from harshicorp. Seems it is best to call it terraform-plugin or others to differentiate from the terraform binary from harshicorp.