search

docker-archive / deploykit

A toolkit for creating and managing declarative, self-healing infrastructure.
Apache License 2.0
2.25k stars 262 forks source link

More thorough logging needed throughout #269

Closed wfarner closed 7 years ago

wfarner commented 7 years ago

From comment in #83:

We really need to enhance the logging support. First of all, all logging should have timestamp. 2nd, the current code has little or no log, it is really hard to debug things when stuff goes wrong.

I concur with this statement that we should make a pass through major components to ensure that debug-level logging is more thorough.

linsun commented 7 years ago

Thank you @wfarner for opening this!

wfarner commented 7 years ago

@linsun i'm going to take a pass at this over the next few days. If there are any particular bodies of code where you would like to see more logging, feel free to drop a list here!

linsun commented 7 years ago

@wfarner Thanks for asking! I would like to see log finest level for entry/exit into any method, that is helpful when troubleshooting things. I would like to see info level logs associated to key actions, like group watch request received, group is being destroyed, group is being created. I would like to see appropriate error and warning message in the logs. When there is something wrong, would be great to see where the error was first occurred, whether this is a user error where user can potentially correct in group.json or plugin error or infrakit code error. For example, I recently tried rolling upgrade, but it didn't work for me, there was not much log at all other than it did detect that I requested an increase of 1 more instance number, but it also keeps saying "Waiting for scaler to quiesce"...

wfarner commented 7 years ago

@linsun thanks. I agree with everything except logging every method. However, i was looking to add full RPC request/response logging, which might be in a similar vein without as much upkeep/noise.

linsun commented 7 years ago

@wfarner logging every method is something I am debating myself too, i think it is great to have at the finest logging level. I totally agree with you the request/response logging would be awesome!