search

docker-archive / deploykit

A toolkit for creating and managing declarative, self-healing infrastructure.
Apache License 2.0
2.25k stars 262 forks source link

Validate common name and notes are not nil. #771

Closed craigyam closed 6 years ago

craigyam commented 6 years ago

In the IBM Cloud provider load balancer, need to check that the cert fields are not nil. Hit an issue where if the notes field of the SSL certificate was not set, the code would panic.

Signed-off-by: Craig Yamamoto craigyam@us.ibm.com

codecov[bot] commented 6 years ago

Codecov Report

Merging #771 into master will decrease coverage by 0.03%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #771      +/-   ##
==========================================
- Coverage   49.06%   49.03%   -0.04%     
==========================================
  Files          84       84              
  Lines        9322     9322              
==========================================
- Hits         4574     4571       -3     
- Misses       4399     4401       +2     
- Partials      349      350       +1
Impacted Files Coverage Δ
pkg/types/spec.go 51.82% <0%> (-2.19%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 822bfd8...061bd60. Read the comment docs.