docker-archive / deploykit

A toolkit for creating and managing declarative, self-healing infrastructure.
Apache License 2.0
2.25k stars 262 forks source link

Update the softlayer go version. #807

Closed craigyam closed 6 years ago

craigyam commented 6 years ago

The softlayer-go version needs to be updated to the latest to pull in support for retries on rate limit exceeded errors. Also need to enable the retry support on the softlayer-go sessions.

codecov[bot] commented 6 years ago

Codecov Report

Merging #807 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #807   +/-   ##
=======================================
  Coverage   48.89%   48.89%           
=======================================
  Files          84       84           
  Lines        7628     7628           
=======================================
  Hits         3730     3730           
  Misses       3542     3542           
  Partials      356      356

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 94630b6...11f9772. Read the comment docs.

GordonTheTurtle commented 6 years ago

Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:

$ git clone -b "update_softlayer_go" git@github.com:craigyam/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842353875872
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.