docker-archive / deploykit

A toolkit for creating and managing declarative, self-healing infrastructure.
Apache License 2.0
2.25k stars 262 forks source link

Sort configs #813

Closed chungers closed 6 years ago

chungers commented 6 years ago

This PR sorts the set of configs for different controllers (e.g. group, ingress, enrollment) so that group controller is first committed before ingress and enrollment controllers. The ordering is necessary so that we don't have cases where ingress / enrollment controllers cannot find the groups they are supposed to monitor when the daemon restarts or when failing over to a new leader node.

Signed-off-by: David Chung david.chung@docker.com

GordonTheTurtle commented 6 years ago

Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:

$ git clone -b "sort-configs" git@github.com:chungers/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354612288
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

codecov[bot] commented 6 years ago

Codecov Report

Merging #813 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #813   +/-   ##
=======================================
  Coverage   48.88%   48.88%           
=======================================
  Files          84       84           
  Lines        7626     7626           
=======================================
  Hits         3728     3728           
  Misses       3542     3542           
  Partials      356      356

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1ec9a49...1c8c0ea. Read the comment docs.