docker-archive / deploykit

A toolkit for creating and managing declarative, self-healing infrastructure.
Apache License 2.0
2.25k stars 262 forks source link

Fix panic when starting vars plugin out of order #834

Closed chungers closed 6 years ago

chungers commented 6 years ago

Signed-off-by: David Chung david.chung@docker.com

GordonTheTurtle commented 6 years ago

Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:

$ git clone -b "fix-vars-panic" git@github.com:chungers/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354515912
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

codecov[bot] commented 6 years ago

Codecov Report

Merging #834 into master will decrease coverage by 1.06%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #834      +/-   ##
==========================================
- Coverage   48.23%   47.16%   -1.07%     
==========================================
  Files          89       89              
  Lines        7974     7944      -30     
==========================================
- Hits         3846     3747      -99     
- Misses       3771     3836      +65     
- Partials      357      361       +4
Impacted Files Coverage Δ
pkg/util/exec/exec.go 29.37% <0%> (-24.6%) :arrow_down:
pkg/rpc/mux/server.go 42.7% <0%> (-5.21%) :arrow_down:
pkg/provider/terraform/instance/apply.go 66.66% <0%> (-3.08%) :arrow_down:
pkg/provider/terraform/instance/plugin.go 85.24% <0%> (-1.82%) :arrow_down:
pkg/provider/aws/plugin/instance/monitor.go 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eb34ce6...bda1462. Read the comment docs.