docker-archive / deploykit

A toolkit for creating and managing declarative, self-healing infrastructure.
Apache License 2.0
2.25k stars 262 forks source link

Update terraform instance name tag #836

Closed kaufers closed 6 years ago

kaufers commented 6 years ago

Updates the tag key from Name to infrakit.infrakit.name so that it aligns with the other tags.

codecov[bot] commented 6 years ago

Codecov Report

Merging #836 into master will decrease coverage by 0.06%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #836      +/-   ##
==========================================
- Coverage   48.24%   48.18%   -0.07%     
==========================================
  Files          89       89              
  Lines        7980     7980              
==========================================
- Hits         3850     3845       -5     
- Misses       3773     3777       +4     
- Partials      357      358       +1
Impacted Files Coverage Δ
pkg/provider/terraform/instance/plugin.go 87.13% <100%> (ø) :arrow_up:
pkg/rpc/mux/server.go 42.7% <0%> (-5.21%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7e467bd...1a22dd6. Read the comment docs.

GordonTheTurtle commented 6 years ago

Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:

$ git clone -b "tf-instance-name-tag" git@github.com:kaufers/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842353700976
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.