docker-archive / deploykit

A toolkit for creating and managing declarative, self-healing infrastructure.
Apache License 2.0
2.25k stars 262 forks source link

swarm manager update: demote node then leave in flavor.Drain #841

Closed chungers closed 6 years ago

chungers commented 6 years ago

This PR address #838 by

Signed-off-by: David Chung david.chung@docker.com

GordonTheTurtle commented 6 years ago

Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:

$ git clone -b "rolling-update-managers" git@github.com:chungers/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354610248
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

codecov[bot] commented 6 years ago

Codecov Report

Merging #841 into master will decrease coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #841      +/-   ##
==========================================
- Coverage   48.45%   48.43%   -0.03%     
==========================================
  Files          89       89              
  Lines        8007     8009       +2     
==========================================
- Hits         3880     3879       -1     
- Misses       3770     3773       +3     
  Partials      357      357
Impacted Files Coverage Δ
pkg/plugin/group/state.go 83.01% <100%> (-0.32%) :arrow_down:
pkg/plugin/group/rollingupdate.go 93.68% <100%> (+2.37%) :arrow_up:
pkg/rpc/mux/server.go 42.7% <0%> (-5.21%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fa1fed5...f8af064. Read the comment docs.