search

docker-archive / deploykit

A toolkit for creating and managing declarative, self-healing infrastructure.
Apache License 2.0
2.25k stars 262 forks source link

Pace quorum group rolling updates #844

Closed kaufers closed 6 years ago

kaufers commented 6 years ago

Currently, the Allocation.Size value is used to determine group size; this only works for scaler groups, for quorum groups we need to use the Allocation.LogicalIDs value.

codecov[bot] commented 6 years ago

Codecov Report

Merging #844 into master will increase coverage by 0.06%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #844      +/-   ##
==========================================
+ Coverage   48.36%   48.43%   +0.06%     
==========================================
  Files          89       89              
  Lines        7993     8007      +14     
==========================================
+ Hits         3866     3878      +12     
- Misses       3770     3771       +1     
- Partials      357      358       +1
Impacted Files Coverage Δ
pkg/plugin/group/rollingupdate.go 91.3% <100%> (+1.56%) :arrow_up:
pkg/types/spec.go 58.4% <0%> (-1.77%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 452942c...c8d5b5c. Read the comment docs.