Closed kaufers closed 6 years ago
:exclamation: No coverage uploaded for pull request base (
master@3484afd
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #845 +/- ##
=========================================
Coverage ? 48.49%
=========================================
Files ? 89
Lines ? 8009
Branches ? 0
=========================================
Hits ? 3884
Misses ? 3769
Partials ? 356
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3484afd...123bfa1. Read the comment docs.
Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:
$ git clone -b "swarm-group-inst-plugins" git@github.com:kaufers/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842353359616
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f
Amending updates the existing PR. You DO NOT need to open a new one.
Swarm instance plugin: Implements
DescribeInstances
andDestroy
onlyDescribeInstances
returns all swarm nodes (no filtering) with the swarm node ID as the instanceID
, the "link-label" as theLogicalID
, all engine labels as theTags
(plus aname
tag added with the nodehostname
), and the entire node struct as theProperties
.Destroy
still needs to be implemented.Swarm group plugin: Implements
DescribeGroup
andSize
onlyDescribeGroup
retrieves all swarm nodes from the instance plugin and excludes any nodes without aLogicalID
(those that do no have a "link-label") and and that are not in aready
state.Size
returns the number of nodes with the same filtering asDescribeGroup
.