docker-archive / deploykit

A toolkit for creating and managing declarative, self-healing infrastructure.
Apache License 2.0
2.25k stars 262 forks source link

Swarm flavor group and instance plugins #845

Closed kaufers closed 6 years ago

kaufers commented 6 years ago

Swarm instance plugin: Implements DescribeInstances and Destroy only

Swarm group plugin: Implements DescribeGroup and Size only

codecov[bot] commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@3484afd). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #845   +/-   ##
=========================================
  Coverage          ?   48.49%           
=========================================
  Files             ?       89           
  Lines             ?     8009           
  Branches          ?        0           
=========================================
  Hits              ?     3884           
  Misses            ?     3769           
  Partials          ?      356

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3484afd...123bfa1. Read the comment docs.

GordonTheTurtle commented 6 years ago

Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:

$ git clone -b "swarm-group-inst-plugins" git@github.com:kaufers/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842353359616
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.