search

docker-archive / deploykit

A toolkit for creating and managing declarative, self-healing infrastructure.
Apache License 2.0
2.25k stars 262 forks source link

Use node version ID during manager drain #848

Closed kaufers closed 6 years ago

kaufers commented 6 years ago

Currently the swarm version is passed when issuing the NodeUpdate, resulting in:

EROR[02-01|21:23:15] Failed to drain
err="Error response from daemon: rpc error: code = 2 desc = update out of sequence"

The fix is to use the node version.

codecov[bot] commented 6 years ago

Codecov Report

Merging #848 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #848   +/-   ##
=======================================
  Coverage   48.52%   48.52%           
=======================================
  Files          89       89           
  Lines        8015     8015           
=======================================
  Hits         3889     3889           
  Misses       3770     3770           
  Partials      356      356

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cf04d2a...2bedb4f. Read the comment docs.