search

docker-archive / deploykit

A toolkit for creating and managing declarative, self-healing infrastructure.
Apache License 2.0
2.25k stars 262 forks source link

Expose Destroy error during rolling updates #850

Closed kaufers closed 6 years ago

kaufers commented 6 years ago

Currently, when the instance Destroy fails, the error does not stop the loop that is waiting for the group is quiese. The loop then will never terminate because no replacment instance will ever be Provision'd because the Destroy failed.

The fix is to expose the Destroy error so that the loop is terminated.

This also updates the UT flow to use custom tag values to denote when the test plugin should return an error.

codecov[bot] commented 6 years ago

Codecov Report

Merging #850 into master will increase coverage by 0.06%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #850      +/-   ##
==========================================
+ Coverage   48.45%   48.52%   +0.06%     
==========================================
  Files          89       89              
  Lines        8015     8019       +4     
==========================================
+ Hits         3884     3891       +7     
+ Misses       3774     3772       -2     
+ Partials      357      356       -1
Impacted Files Coverage Δ
pkg/plugin/group/rollingupdate.go 93.81% <100%> (+0.13%) :arrow_up:
pkg/plugin/group/testplugin.go 77.01% <100%> (+0.54%) :arrow_up:
pkg/plugin/group/scaled.go 79.79% <0%> (+3.03%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ea1b912...009491f. Read the comment docs.