codecov[bot]
commented
6 years ago Codecov Report
Merging #855 into master will increase coverage by
<.01%. The diff coverage is70%.
@@ Coverage Diff @@
## master #855 +/- ##
==========================================
+ Coverage 48.46% 48.46% +<.01%
==========================================
Files 88 89 +1
Lines 7965 8125 +160
==========================================
+ Hits 3860 3938 +78
- Misses 3754 3817 +63
- Partials 351 370 +19| Impacted Files | Coverage Δ | |
|---|---|---|
| pkg/controller/group/lazy.go | 64.1% <ø> (ø) |
|
| pkg/controller/group/rollingupdate.go | 93.81% <ø> (ø) |
|
| pkg/controller/group/state.go | 83.01% <ø> (ø) |
|
| pkg/controller/group/testplugin.go | 77.01% <ø> (ø) |
|
| pkg/controller/group/scaler.go | 90.6% <ø> (ø) |
|
| pkg/controller/group/quorum.go | 88.37% <ø> (ø) |
|
| pkg/controller/group/scaled.go | 79.79% <ø> (ø) |
|
| pkg/controller/group/group.go | 45.54% <63.63%> (ø) |
|
| pkg/controller/group/controller.go | 48.75% <77.77%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 76faf09...1392296. Read the comment docs.
This PR is a simple refactoring to make the code location consistent with the terminology.
Specifically, the entity that enforces desired state of Groups is a Group Controller. A group controller implements the plugin.Group spi. With this change we aim to separate what infrakit provides as common controllers (eg. group, ingress, and enrollment) and user-extensible plugins (instance, flavor, metadata, and events).
Signed-off-by: David Chung david.chung@docker.com