docker-archive / deploykit

A toolkit for creating and managing declarative, self-healing infrastructure.
Apache License 2.0
2.25k stars 262 forks source link

Flavor updates #859

Closed kaufers closed 6 years ago

kaufers commented 6 years ago
codecov[bot] commented 6 years ago

Codecov Report

Merging #859 into master will increase coverage by 10.92%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #859       +/-   ##
===========================================
+ Coverage   48.46%   59.39%   +10.92%     
===========================================
  Files          89       17       -72     
  Lines        8125     1559     -6566     
===========================================
- Hits         3938      926     -3012     
+ Misses       3817      533     -3284     
+ Partials      370      100      -270
Impacted Files Coverage Δ
pkg/controller/group/rollingupdate.go 93.75% <ø> (-0.07%) :arrow_down:
pkg/types/error.go
pkg/types/duration.go
pkg/provider/google/plugin/instance/util/name.go
pkg/types/object.go
pkg/plugin/metadata/lazy.go
...der/aws/plugin/instance/cloudwatchlogs_loggroup.go
pkg/types/depend.go
pkg/plugin/metadata/updatable.go
pkg/util/ssh/conn.go
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7dc06d8...135d0d9. Read the comment docs.

GordonTheTurtle commented 6 years ago

Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:

$ git clone -b "flavor-updates-updates" git@github.com:kaufers/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842353946464
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.