search

docker-archive / deploykit

A toolkit for creating and managing declarative, self-healing infrastructure.
Apache License 2.0
2.25k stars 262 forks source link

Update enrolling logging #860

Closed kaufers closed 6 years ago

kaufers commented 6 years ago

We log an Info message with the full Instance.Description value whenever an instance is added or removed; this gets really noisy for VMs since the full userdata value (with the full boot script) is logged.

This commit updates this flow so that the instance ID is logged or, if the LogicalID is set, then the instance ID:LogicalID is logged in the Info message.

codecov[bot] commented 6 years ago

Codecov Report

Merging #860 into master will increase coverage by 0.02%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #860      +/-   ##
==========================================
+ Coverage   48.44%   48.46%   +0.02%     
==========================================
  Files          89       89              
  Lines        8125     8125              
==========================================
+ Hits         3936     3938       +2     
+ Misses       3818     3817       -1     
+ Partials      371      370       -1
Impacted Files Coverage Δ
pkg/types/spec.go 60.17% <0%> (+1.76%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 02cfc32...841f048. Read the comment docs.