search

docker-archive / deploykit

A toolkit for creating and managing declarative, self-healing infrastructure.
Apache License 2.0
2.25k stars 262 forks source link

Refactor - move instance.Descriptions operations to common spi package #863

Closed chungers closed 6 years ago

chungers commented 6 years ago

Signed-off-by: David Chung david.chung@docker.com

GordonTheTurtle commented 6 years ago

Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:

$ git clone -b "links" git@github.com:chungers/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354331816
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

codecov[bot] commented 6 years ago

Codecov Report

Merging #863 into master will increase coverage by 0.11%. The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #863      +/-   ##
==========================================
+ Coverage   48.77%   48.89%   +0.11%     
==========================================
  Files          89       91       +2     
  Lines        8162     8206      +44     
==========================================
+ Hits         3981     4012      +31     
- Misses       3814     3825      +11     
- Partials      367      369       +2
Impacted Files Coverage Δ
pkg/spi/instance/types.go 100% <100%> (ø)
pkg/spi/instance/description.go 80.48% <81.48%> (ø)
pkg/rpc/mux/server.go 42.7% <0%> (-5.21%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a749d24...3253dff. Read the comment docs.