search

docker-archive / deploykit

A toolkit for creating and managing declarative, self-healing infrastructure.
Apache License 2.0
2.25k stars 262 forks source link

Fix racey Manager "TestStartOneLeader" test #865

Closed kaufers closed 6 years ago

kaufers commented 6 years ago

This was introduced in https://github.com/docker/infrakit/pull/856

Now that a 2nd CommitGroup is being executed on leadership, we need to synchronize after the 2nd API call. Note that this work was completed for the other test in this package, TestChangeLeadership, and the same logic needs to be applied to the TestStartOneLeader test.

codecov[bot] commented 6 years ago

Codecov Report

Merging #865 into master will decrease coverage by 0.02%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #865      +/-   ##
==========================================
- Coverage   48.95%   48.92%   -0.03%     
==========================================
  Files          91       91              
  Lines        8206     8206              
==========================================
- Hits         4017     4015       -2     
- Misses       3821     3822       +1     
- Partials      368      369       +1
Impacted Files Coverage Δ
pkg/types/spec.go 58.4% <0%> (-1.77%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cc05c10...52b78d5. Read the comment docs.