Closed kaufers closed 6 years ago
Merging #866 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #866 +/- ##
=======================================
Coverage 48.78% 48.78%
=======================================
Files 91 91
Lines 8210 8210
=======================================
Hits 4005 4005
Misses 3835 3835
Partials 370 370
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 428fc87...cc25171. Read the comment docs.
Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:
$ git clone -b "tf-bootstrap-config-hash" git@github.com:kaufers/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842353798896
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f
Amending updates the existing PR. You DO NOT need to open a new one.
We want to keep the import flow generic. Currently, the tf plugin assumes that the VM being imported is the initial manager and it sets the
infrakit.config.hash=bootstrap
tag. Instead of doing this in the plugin, the initial VM should simply be created with this tag; this is consistent with how theinfrakit-link=bootstrap
tag needs to be set.