search

docker-archive / deploykit

A toolkit for creating and managing declarative, self-healing infrastructure.
Apache License 2.0
2.25k stars 262 forks source link

Remove Flavor Options.Self #868

Closed kaufers closed 6 years ago

kaufers commented 6 years ago

This value was only used when removing a manager node from the swarm and this function was removed in https://github.com/docker/infrakit/pull/859

Since the Self value is no longer needed, this commit removes the option.

codecov[bot] commented 6 years ago

Codecov Report

Merging #868 into master will increase coverage by 0.01%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #868      +/-   ##
==========================================
+ Coverage   48.77%   48.78%   +0.01%     
==========================================
  Files          91       91              
  Lines        8211     8211              
==========================================
+ Hits         4005     4006       +1     
  Misses       3835     3835              
+ Partials      371      370       -1
Impacted Files Coverage Δ
pkg/rpc/mux/server.go 42.7% <0%> (-5.21%) :arrow_down:
pkg/types/spec.go 60.17% <0%> (+1.76%) :arrow_up:
pkg/spi/instance/description.go 80.48% <0%> (+9.75%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c54260d...5460ee8. Read the comment docs.