docker-archive / deploykit

A toolkit for creating and managing declarative, self-healing infrastructure.
Apache License 2.0
2.25k stars 264 forks source link

Populate LogicalID in DigitalOcean DescribeInstances #871

Closed johnmccabe closed 6 years ago

johnmccabe commented 6 years ago

Prior to this PR the LogicalID wasn't being populated in the instance.Description structs returned by DescribeInstances().

This change sets the LogicalID if found in the listed Droplets.

codecov[bot] commented 6 years ago

Codecov Report

Merging #871 into master will decrease coverage by 0.01%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #871      +/-   ##
==========================================
- Coverage   48.83%   48.82%   -0.02%     
==========================================
  Files          91       91              
  Lines        8213     8213              
==========================================
- Hits         4011     4010       -1     
  Misses       3833     3833              
- Partials      369      370       +1
Impacted Files Coverage Δ
pkg/types/spec.go 58.4% <0%> (-1.77%) :arrow_down:
pkg/spi/instance/description.go 82.92% <0%> (+2.43%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2acbfc7...16c58aa. Read the comment docs.