Closed chungers closed 6 years ago
Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:
$ git clone -b "gc-controller" git@github.com:chungers/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354176288
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f
Amending updates the existing PR. You DO NOT need to open a new one.
Merging #876 into master will increase coverage by
0.3%
. The diff coverage is66.29%
.
@@ Coverage Diff @@
## master #876 +/- ##
=========================================
+ Coverage 48.93% 49.23% +0.3%
=========================================
Files 91 93 +2
Lines 8221 8345 +124
=========================================
+ Hits 4023 4109 +86
- Misses 3830 3868 +38
Partials 368 368
Impacted Files | Coverage Δ | |
---|---|---|
pkg/controller/group/controller.go | 48.75% <ø> (ø) |
:arrow_up: |
pkg/spi/controller/lazy.go | 70.37% <ø> (ø) |
|
pkg/types/duration.go | 67.56% <100%> (+12.01%) |
:arrow_up: |
pkg/spi/group/lazy.go | 64.1% <57.89%> (ø) |
|
pkg/plugin/instance/lazy.go | 63.33% <63.33%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d92935a...290efd1. Read the comment docs.
This controller implements the garbage collection algorithm described in #846
Closes #846
Signed-off-by: David Chung david.chung@docker.com