docker-archive / deploykit

A toolkit for creating and managing declarative, self-healing infrastructure.
Apache License 2.0
2.25k stars 264 forks source link

Fix interval calculation for minimum tick size #879

Closed chungers closed 6 years ago

chungers commented 6 years ago

GC controller uses a FSM model that requires a clock to determine how long to wait before terminating instances, etc. This PR makes sure that the clock tick is sized to be largest of the sampling interval between the NodeObserver, InstanceObserver, and the configured tick size.

Signed-off-by: David Chung david.chung@docker.com

codecov[bot] commented 6 years ago

Codecov Report

Merging #879 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #879   +/-   ##
=======================================
  Coverage   48.55%   48.55%           
=======================================
  Files          94       94           
  Lines        8448     8448           
=======================================
  Hits         4102     4102           
  Misses       3980     3980           
  Partials      366      366

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b20ff23...c587b51. Read the comment docs.