docker-archive / deploykit

A toolkit for creating and managing declarative, self-healing infrastructure.
Apache License 2.0
2.25k stars 264 forks source link

Resource Controller #880

Closed chungers closed 6 years ago

chungers commented 6 years ago

This PR

See the README.md in docs/controller/resource/README.md for details.

Signed-off-by: David Chung david.chung@docker.com

codecov[bot] commented 6 years ago

Codecov Report

Merging #880 into master will decrease coverage by 0.01%. The diff coverage is 43.39%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #880      +/-   ##
=========================================
- Coverage   48.41%   48.4%   -0.02%     
=========================================
  Files          84      85       +1     
  Lines        7698    7741      +43     
=========================================
+ Hits         3727    3747      +20     
- Misses       3671    3691      +20     
- Partials      300     303       +3
Impacted Files Coverage Δ
pkg/template/funcs.go 62.97% <0%> (-0.49%) :arrow_down:
pkg/spi/event/types.go 59.52% <20%> (-4.58%) :arrow_down:
pkg/spi/controller/singleton.go 42.42% <42.42%> (ø)
pkg/types/link.go 93.93% <50%> (-6.07%) :arrow_down:
pkg/types/path.go 84.92% <80%> (-0.12%) :arrow_down:
pkg/rpc/mux/server.go 47.91% <0%> (+5.2%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a496941...5ed3ec0. Read the comment docs.

GordonTheTurtle commented 6 years ago

Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:

$ git clone -b "resource-controller" git@github.com:chungers/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354172632
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.