search

docker-archive / deploykit

A toolkit for creating and managing declarative, self-healing infrastructure.
Apache License 2.0
2.25k stars 264 forks source link

Inventory controller #888

Closed chungers closed 6 years ago

chungers commented 6 years ago

Inventory controller: a controller that monitors resources from different instance plugins.
This controller exposes the event and metadata interfaces so that as resources are provisioned or destroyed, events can be seen via the /found and /lost topics. It also exposes metadata interface so that the properties of resources can be queried in a path-like manner.

Docs/playbooks available in docs/controller/inventory/playbook.yml

Signed-off-by: David Chung david.chung@docker.com

codecov[bot] commented 6 years ago

Codecov Report

Merging #888 into master will increase coverage by 0.04%. The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #888      +/-   ##
==========================================
+ Coverage   48.61%   48.66%   +0.04%     
==========================================
  Files          85       85              
  Lines        7787     7790       +3     
==========================================
+ Hits         3786     3791       +5     
+ Misses       3693     3692       -1     
+ Partials      308      307       -1
Impacted Files Coverage Δ
pkg/spi/controller/singleton.go 38.88% <40%> (-3.54%) :arrow_down:
pkg/rpc/mux/server.go 47.91% <0%> (+5.2%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3f917be...001ee9d. Read the comment docs.

GordonTheTurtle commented 6 years ago

Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:

$ git clone -b "inventory-controller" git@github.com:chungers/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354511496
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.