Closed chungers closed 6 years ago
Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:
$ git clone -b "aws-resources" git@github.com:chungers/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354174864
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f
Amending updates the existing PR. You DO NOT need to open a new one.
Merging #890 into master will decrease coverage by
0.2%
. The diff coverage is1.72%
.
@@ Coverage Diff @@
## master #890 +/- ##
==========================================
- Coverage 48.66% 48.46% -0.21%
==========================================
Files 85 84 -1
Lines 7790 7812 +22
==========================================
- Hits 3791 3786 -5
- Misses 3692 3718 +26
- Partials 307 308 +1
Impacted Files | Coverage Δ | |
---|---|---|
...ws/plugin/instance/autoscaling_autoscalinggroup.go | 0% <0%> (ø) |
:arrow_up: |
...rovider/aws/plugin/instance/ec2_internetgateway.go | 0% <0%> (ø) |
:arrow_up: |
pkg/provider/aws/plugin/instance/ec2_routetable.go | 0% <0%> (ø) |
:arrow_up: |
pkg/provider/aws/plugin/instance/ec2_volume.go | 0% <0%> (ø) |
:arrow_up: |
.../provider/aws/plugin/instance/ec2_spot_instance.go | 0% <0%> (ø) |
:arrow_up: |
pkg/provider/aws/plugin/instance/ec2_vpc.go | 0% <0%> (ø) |
:arrow_up: |
pkg/provider/aws/plugin/instance/builder.go | 0% <0%> (ø) |
:arrow_up: |
.../provider/aws/plugin/instance/ec2_securitygroup.go | 0% <0%> (ø) |
:arrow_up: |
pkg/provider/aws/plugin/instance/ec2_subnet.go | 0% <0%> (ø) |
:arrow_up: |
pkg/provider/aws/plugin/instance/ec2_instance.go | 35.21% <33.33%> (ø) |
:arrow_up: |
... and 1 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f7b80b0...1264f89. Read the comment docs.
This PR
properties=true
bool flag when Describing instances to return properties of resourcesmystack.yml
that will create a full VPC with 1 internet gateway and 2 subnetsinventory.yml
for configuring the inventory controller which will monitor all the resources created by the resource controller (as driven bymystack.yml
) and make all the resource properties (e.g. VpcId) be available in metadata form.See
examples/playbook/aws/README.md
for how to use.Signed-off-by: David Chung david.chung@docker.com