Closed johnmccabe closed 6 years ago
Merging #895 into master will increase coverage by
0.02%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #895 +/- ##
==========================================
+ Coverage 48.53% 48.56% +0.02%
==========================================
Files 84 84
Lines 7837 7837
==========================================
+ Hits 3804 3806 +2
+ Misses 3722 3721 -1
+ Partials 311 310 -1
Impacted Files | Coverage Δ | |
---|---|---|
pkg/types/spec.go | 60.17% <0%> (+1.76%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 365de38...f11e866. Read the comment docs.
The currently pinned dependencies have two problems that are highlighted when attempting to vendor new dependencies or reproduce the vendor directory from the
Gopkg.lock
file (I'd encountered these while investigating building on windows).hpcloud/tail
has a transitive dependency to a no-longer existing repo.k8s.io/apimachinery
pins to an invalid revisionIf you wipe the
vendor
directory and attempt to reproduce it viadep ensure -v
you should see something similar to the following:hpcloud/tail
/fsnotify
fixThis PR pins the
hpcloud/tail
dependency to the fix in the PR branch for hpcloud/tail#138 which addresses problems due to thefsnotify
Github org name changing fromgo-fsnotify
tofsnotify
(see go-fsnotify/fsnotify#1).This change also effectively bumps the vendored
hpcloud/tail
version to1.4.7
, no impact to CI tests have been observed.When this upstream PR is merged we can point again at the
hpcloud/tail
repo.k8s.io/apimachinery
fixThis commit also addresses an issue introduced when migrating the dependencies from Rancher Trash to
dep
, thedep init
used to populate theGopkg.toml
file had interpreted the pinned value fork8s.io/apimachinery
as a revision and not the branch which it pointed to.The fix involves pinning
k8s.io/apimachinery
to therelease-1.7
branch again in an override.It should be possible to remove this when moving the
k8s.io/kubernetes
dependency to a version> 1.7.5
(there is no corresponding1.7.5
tag on the apimachinery project, the earliest being1.7.6
).