Closed Vanuan closed 5 years ago
Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:
$ git clone -b "patch-1" git@github.com:Vanuan/infrakit.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f
Amending updates the existing PR. You DO NOT need to open a new one.
Merging #912 into master will increase coverage by
0.08%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #912 +/- ##
==========================================
+ Coverage 48.33% 48.42% +0.08%
==========================================
Files 84 84
Lines 7859 7859
==========================================
+ Hits 3799 3806 +7
+ Misses 3748 3743 -5
+ Partials 312 310 -2
Impacted Files | Coverage Δ | |
---|---|---|
pkg/types/spec.go | 60.17% <0%> (+1.76%) |
:arrow_up: |
pkg/rpc/mux/server.go | 47.91% <0%> (+5.2%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a10d75e...450a655. Read the comment docs.
It's either a typo or a change in behavior.
infrakit playbook linuxkit -h
doesn't work.Changed to
infrakit use linuxkit -h