docker-archive / docker-registry

This is **DEPRECATED**! Please go to https://github.com/docker/distribution
Apache License 2.0
2.88k stars 879 forks source link

Support for Redis sentinel (Cache, LRU) #575

Open huangsam opened 10 years ago

huangsam commented 10 years ago

After searching for notes for how to utilize a containerized Redis sentinel with little to no success on docker-registry, I found some hint of it in https://github.com/docker/docker-registry/pull/416, https://github.com/docker/docker-registry/issues/528 and http://redis.io/topics/sentinel. My team recently tried utilizing it, but we kept encountering WARNING: LRU: Redis connection error: Error 111 connecting 10.244.1.85:6379. Connection refused. We also changed to utilizing port 26379, but it did not appear to work. It was only when we utilized the containerized Redis master that no more issues were popping up when we did docker logs on the registry container. Is there existing support for sentinels? Kind of curious since discussion on the matter is fairly sparse.

shin- commented 10 years ago

Hi, Sorry – that's not something we support at the time. A patch adding sentinel support would of course be most welcome :)

huangsam commented 10 years ago

That makes sense. My team and I will look into this for the coming two weeks. Feel free to check this link out as it helped us think in the right direction. Should I close this issue, or keep it hanging for a while?

dmp42 commented 10 years ago

Let's keep it open, and see if someone comes up with a PR.

Best.

rvRamakrishnan commented 6 years ago

I know this an old issue. But does recent versions of Docker Registry started supporting Redis with Sentinel?