search

docker-archive / docker-registry

This is **DEPRECATED**! Please go to https://github.com/docker/distribution
Apache License 2.0
2.88k stars 879 forks source link

paginate search results in /v1/search #715

Open Nowaker opened 9 years ago

Nowaker commented 9 years ago

As seen here, it's not possible to limit the search to, say, 10 elements. Results are sorted by the number of stars, so usually it's TOP10 what people really want to get. Current approach is extremely slow - just try docker search ubuntu or http --json GET https://index.docker.io/v1/search?q=ubuntu. JSON encoding (server-side) and parsing (client-side) probably takes most of the time. Limiting the result set to 10 elements would speed things up. And even if not, it's still very convenient to have a way to limit the number of results.

dmp42 commented 9 years ago

Thanks a lot for the report.

The official search endpoint (index.docker.io) is not using the docker-registry implementation, so, I assume these to be two (somewhat) different matters. I reported the issue on index to the hub team.

Now, about the registry implementation itself, do you experience slow results with your private registry?

Nowaker commented 9 years ago

Well, no, I encountered it with index.docker.io. I didn't want to report this without checking the source code first, found this repo, and had a look. I didn't know it's a different project, even though I was somewhat hinted.

Still, even if it's not going to speed things up, it's still very convenient to have a way to limit the number of results.

dmp42 commented 9 years ago

Agreed.