'true' result always return, when setting invalid data to 'access' properties

docker-archive / docker-registry

This is **DEPRECATED**! Please go to https://github.com/docker/distribution

Apache License 2.0

2.88k stars 879 forks source link

'true' result always return, when setting invalid data to 'access' properties #934

Closed xiekeyang closed 9 years ago

xiekeyang commented 9 years ago

When setting properties of some repo, I found it reject invalid data. However, the response is always 'true', which seems to be some incorrect. right? for example: PUT -H "Content-Type: application/json" -k http://myregistry.io/v1/repositories/foo/bar/properties -d '{"access": "(invalid data)"}' true if it is a bug? Maybe we should add a judgement in registry properties function, which impact little to performance. Thanks

xiekeyang commented 9 years ago

PUT properties methods lie in registry code. but it seems to do nothing. maybe develops can do it in their own index. However, if it had better to be available and to be useful user, to be fixed? Thanks.