search

docker-archive / for-aws

92 stars 26 forks source link

Cloudstor support for proxy #168

Open RichardWLaub opened 6 years ago

RichardWLaub commented 6 years ago

Expected behavior

We should be able to set an http_proxy environment variable with the cloudstor plugin. This way cloudstor can still make the AWS requests it needs to when we are running in environments that require a proxy.

Actual behavior

HTTP_PROXY is not a valid environment variable for the cloudstor plugin configuration.

Steps to reproduce the behavior

  1. Run the following command:
$ docker plugin install --alias cloudstor:aws --grant-all-permissions docker4x/cloudstor:17.06.2-ee-6-aws2 AWS_REGION=us-west-2 CLOUD_PLATFORM=AWS EFS_SUPPORTED=0 DEBUG=1 HTTP_PROXY=myproxy.com
17.06.2-ee-6-aws2: Pulling from docker4x/cloudstor
14a5149d2aad: Download complete
Digest: sha256:c285ada14ad2f8e17ffe982abcc5bffaceaa678493d349774b727ffa291bdbec
Status: Downloaded newer image for docker4x/cloudstor:17.06.2-ee-6-aws2
Error response from daemon: setting "HTTP_PROXY" not found in the plugin configuration
silent-vim commented 5 years ago

+1, even the proxy configuration set for the docker daemon is ignored.

sleavitt commented 5 years ago

+1 The docker daemon is configured properly to use the http proxy, I don't understand why the plugin can't leverage that. If a proxy is properly configured in the docker daemon, cloudstor should just transparently use it.