docker-archive / for-aws

92 stars 26 forks source link

Please enable Group Metrics Collection on the ASGs #60

Open hairyhenderson opened 7 years ago

hairyhenderson commented 7 years ago

It'd be very useful to be able to monitor ASG events with CloudWatch, but for that to work we need "Group Metrics Collection" enabled.

I believe there's some cost involved to this setting, so it may be useful to make this optional to avoid incurring cost.

The option is documented here: http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-as-group.html#cfn-as-group-metricscollection

EtienneDufresne commented 7 years ago

In the mean time you can use this sed command will patch the template to enable metrics collection on the manager ASG:

sed '/\"DesiredCapacity\": {/{n;/\"Ref\": \"ManagerSize\"/{n;/},/a\"MetricsCollection\": [ { \"Granularity\" : \"1Minute\" } ],'$'\n''}''}'
kencochrane commented 7 years ago

Looking at this blog post, it looks like it is free. If that is truly the case, maybe we just enable it by default, unless anyone knows of a reason why someone might not want this turned on?

https://aws.amazon.com/about-aws/whats-new/2016/08/free-auto-scaling-group-metrics-with-graphs/

hairyhenderson commented 7 years ago

@kencochrane ah - I was conflating it with the EC2 detailed instance monitoring

In that case, no reason to not turn this on by default! 👍

kencochrane commented 7 years ago

@hairyhenderson thanks, I have made the change, it will be available in 17.07

hairyhenderson commented 7 years ago

Thanks! 🎉

hairyhenderson commented 7 years ago

I see this appeared in 17.07.0-ce-aws1 today in edge - thanks again @kencochrane!

hairyhenderson commented 6 years ago

@kencochrane @FrenchBen should this be closed? It's been available...