search

docker-archive / go-p9p

A modern, performant 9P library for Go.
Apache License 2.0
206 stars 50 forks source link

Specify type for all constants, not just the first #23

Closed dominikh closed 8 years ago

dominikh commented 8 years ago

Closes #22

codecov-io commented 8 years ago

Current coverage is 15.91% (diff: 100%)

Merging #23 into master will not change coverage

@@             master        #23   diff @@
==========================================
  Files            13         13          
  Lines          1131       1131          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            180        180          
  Misses          903        903          
  Partials         48         48

Powered by Codecov. Last update 87c6cf4...f970a77

thaJeztah commented 8 years ago

ping @stevvooe PTAL

stevvooe commented 8 years ago

@thaJeztah @dominikh See https://github.com/docker/go-p9p/issues/22#issuecomment-239538912.

Otherwise, this looks okay.