search

docker-archive / go-p9p

A modern, performant 9P library for Go.
Apache License 2.0
206 stars 50 forks source link

Fix EOF indication from Readdir #39

Closed titanous closed 6 years ago

titanous commented 7 years ago

EOF is indicated by a zero-length result with no error, so ensure that io.EOF does not ever get returned by Readdir.Read.

codecov[bot] commented 7 years ago

Codecov Report

Merging #39 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #39   +/-   ##
======================================
  Coverage    22.3%   22.3%           
======================================
  Files          14      14           
  Lines        1179    1179           
======================================
  Hits          263     263           
  Misses        855     855           
  Partials       61      61
Impacted Files Coverage Δ
readdir.go 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 87ae851...33d1516. Read the comment docs.

stevvooe commented 6 years ago

EOF is indicated by a zero-length result with no error,

@titanous Is this Go stdlib behavior?

titanous commented 6 years ago

It’s the 9p protocol (there is no EOF error).

stevvooe commented 6 years ago

LGTM