Closed titanous closed 6 years ago
Merging #40 into master will increase coverage by
0.06%
. The diff coverage is0%
.
@@ Coverage Diff @@
## master #40 +/- ##
==========================================
+ Coverage 22.3% 22.37% +0.06%
==========================================
Files 14 14
Lines 1179 1171 -8
==========================================
- Hits 263 262 -1
+ Misses 855 848 -7
Partials 61 61
Impacted Files | Coverage Δ | |
---|---|---|
channel.go | 54.31% <0%> (ø) |
:arrow_up: |
encoding.go | 50.65% <0%> (ø) |
:arrow_up: |
transport.go | 0% <0%> (ø) |
:arrow_up: |
server.go | 0% <0%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 87ae851...f2ad3c4. Read the comment docs.
LGTM
@titanous Thanks for the PR.
Ideally logging could be controlled by the user of the server via a struct field somewhere, but start by ensuring that the server only logs in exceptional cases and prefixes each log line with the package name.