docker-archive / infrakit.aws

Infrakit plugins for AWS.
21 stars 22 forks source link

[DO NOT MERGE / experimental] make bootstrap work with failover + us-west-1 #20

Closed chungers closed 7 years ago

chungers commented 7 years ago

Signed-off-by: David Chung david.chung@docker.com

docker-codecov-bot commented 7 years ago

Current coverage is 34.37% (diff: 100%)

Merging #20 into master will not change coverage

@@             master        #20   diff @@
==========================================
  Files             5          5          
  Lines           224        224          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits             77         77          
  Misses          133        133          
  Partials         14         14          

Powered by Codecov. Last update 1651e09...db0055c

GordonTheTurtle commented 7 years ago

Please sign your commits following these rules: https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:

$ git clone -b "bootstrap" https://github.com/chungers/infrakit.aws.git somewhere
$ cd somewhere
$ git rebase -i HEAD~6
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

GordonTheTurtle commented 7 years ago

Please sign your commits following these rules: https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:

$ git clone -b "bootstrap" git@github.com:chungers/infrakit.aws.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842353163640
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.