search

docker-archive / infrakit.aws

Infrakit plugins for AWS.
21 stars 22 forks source link

Update AWS ASG plugin Provision, DescribeInstances #40

Closed mgpoly closed 7 years ago

mgpoly commented 7 years ago

Provision now creates ASG. AutoScalingGroupName is synonymous with LogicalID and ID. DescribeInstaces returns ASG details. Still does not handle Drain request nor cloud-init data - neither are passed on to the Instances beloning to the ASG.

Signed-off-by: Mike Grayson mike@polyverse.io

GordonTheTurtle commented 7 years ago

Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:

$ git clone -b "PW-46" git@github.com:polyverse-security/infrakit.aws.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354080680
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

mgpoly commented 7 years ago

@GordonTheTurtle sigs added, however I'll need to squash the commits?

codecov[bot] commented 7 years ago

Codecov Report

Merging #40 into master will decrease coverage by 0.32%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #40      +/-   ##
=========================================
- Coverage    7.85%   7.52%   -0.33%     
=========================================
  Files          20      20              
  Lines        1057    1103      +46     
=========================================
  Hits           83      83              
- Misses        957    1003      +46     
  Partials       17      17
Impacted Files Coverage Δ
plugin/instance/autoscaling_autoscalinggroup.go 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e072de9...0374ae9. Read the comment docs.

chungers commented 7 years ago

Hi @mgpoly - Thank you for the PR.

I will merge this but in the future, please send your PR over to https://github.com/docker/infrakit/tree/master/pkg/provider/aws/.

We are moving everything in this repo over to the main infrakit repo so that all the plugins are built in sync with the infrakit versions. This is so we can ensure compatibility and consistency, until the interfaces have been finalized and frozen.

Thank you so much. Sorry for the inconvenience. We are in the process of closing this repo. We really appreciate your PR so please send it to the new location so we can all better care for it and collaborate.

Thank you.