Fixes NO_LOGIN after adding ECR support

docker-archive / migrator

Tool to migrate Docker images from Docker Hub or v1 registry to a v2 registry

Apache License 2.0

160 stars 82 forks source link

Fixes NO_LOGIN after adding ECR support #74

Closed mbentley closed 8 years ago

mbentley commented 8 years ago

Signed-off-by: Matt Bentley matt.bentley@docker.com

mbentley commented 8 years ago

@mattnowina - Could you check this to make sure it does not break ECR support? I changed the environment variables that were ECR specific and made this work with the existing naming scheme and I also moved the for loop that creates the repositories to the push_images_to_v2 function since login is irrelevant there so we don't have to deal with both login and creating to the repositories at the same time.

mattnowina commented 8 years ago

@mbentley Changes look good. I was still able to pull and push images from Docker Hub to ECR will no issues.

mbentley commented 8 years ago

Thanks for verifying!

mbentley commented 8 years ago

I was able to get CI to pass after I added another test migration that uses a v2 without login.