search

docker-archive / oscalkit

NIST OSCAL SDK and CLI
https://docker.github.io/oscalkit/
Other
36 stars 23 forks source link

Add implementation code generation #32

Closed minhaj10p closed 5 years ago

minhaj10p commented 5 years ago

Feature: Code generation for Implementation through Excel sheet and input profile. Uses package https://github.com/satori/go.uuid to generate GUIDs Usage: oscalkit implementation -p path-to-profile -e path-to-excelsheet.csv

codecov[bot] commented 5 years ago

Codecov Report

Merging #32 into master will increase coverage by 13.01%. The diff coverage is 92.81%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #32       +/-   ##
===========================================
+ Coverage   65.62%   78.64%   +13.01%     
===========================================
  Files           3        4        +1     
  Lines         160      309      +149     
===========================================
+ Hits          105      243      +138     
- Misses         45       52        +7     
- Partials       10       14        +4
Impacted Files Coverage Δ
generator/mapper.go 81.15% <100%> (ø) :arrow_up:
generator/reader.go 58.82% <60%> (-2.41%) :arrow_down:
impl/implementation.go 93.87% <93.87%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a02bb1f...cdd417d. Read the comment docs.

mohuk commented 5 years ago

@anweiss @minhaj10p Just a comment. I feel this code generation of implementation.go shouldn't be part of OSCALkit since the implementation generated is specific to Docker. I am sure we are going to move this out of OSCALkit down the road.

anweiss commented 5 years ago

LGTM

anweiss commented 5 years ago

@mohuk per your comment, can you create an issue for us to address the Docker-specific code that was merged in this PR at a later point?