search

docker-archive / oscalkit

NIST OSCAL SDK and CLI
https://docker.github.io/oscalkit/
Other
36 stars 23 forks source link

Guidance type should rather be an []string instead of string #74

Closed aitchkhan closed 5 years ago

aitchkhan commented 5 years ago

The guidance present in fedramp baseline implementsProfile[].Parameters[] are an array of multiple p tag. IMHO, guidance in Parameter struct should be of type []string rather than string. https://github.com/docker/oscalkit/blob/42bb04d0ffeec2f1979f895ebfc8ea9819dc9223/types/oscal/implementation/implementation.go#L39

anweiss commented 5 years ago

Fixed by #78.