search

docker-archive / toolbox

The Docker Toolbox
https://docker.com/toolbox
3.21k stars 1.23k forks source link

Set DOCKER_TOOLBOX_INSTALL_PATH for all users on installation #598

Open davclark opened 7 years ago

davclark commented 7 years ago

Currently, DOCKER_TOOLBOX_INSTALL_PATH is only set for the installing user. So, probably for the admin user. If you run Kitematic as a user without this variable set, it won't find the installation and will prompt you to install docker toolbox!

This problem affects multiple users, as evidenced here:

https://forums.docker.com/t/kitematic-wont-launch-unless-i-run-as-administrator/4362/3

The simplest approach would be to set this as a system as opposed to a user variable at install.

davclark commented 7 years ago

This was also the root issue of docker/kitematic#2050

cmarquardt commented 7 years ago

The problem is still there... If a non-admin user installs Docker Toolbox via a local admin account on his Windows PC, that installation goes well, but the PATH is only updated for the local admin account. After installation, the non-admin user thus runs into error messages that docker can't be started.

strarsis commented 6 years ago

+1 Just had this issue in start.sh script.

mattgillard commented 6 years ago

+1 me too. I made a change to get it to work: Line 19 of start.sh is now: DOCKER_MACHINE="$(win_to_unix_path "${DOCKER_TOOLBOX_INSTALL_PATH}")\docker-machine.exe"

it was:

DOCKER_MACHINE="${DOCKER_TOOLBOX_INSTALL_PATH}\docker-machine.exe"

Maybe i should submit a pull request