search

docker-flow / docker-flow-monitor

MIT License
87 stars 38 forks source link

New start. WIP on proxy #72

Closed tuxerrante closed 5 years ago

tuxerrante commented 5 years ago

I had to delete and move most of the files.

vfarcic commented 5 years ago

Sorry for not responding earlier... I was (still am) travelling.

That might be too big of a change at once to be safe to merge to the master branch of the project. Maybe we can do in smaller chunks?

tuxerrante commented 5 years ago

No problem, I have no hurry. How would you like to proceed? Maybe we can merge everything on a branch instead of the master?

On Sat, 28 Sep 2019 at 19:50, Viktor Farcic notifications@github.com wrote:

Sorry for not responding earlier... I was (still am) travelling.

That might be too big of a change at once to be safe to merge to the master branch of the project. Maybe we can do in smaller chunks?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/docker-flow/docker-flow-monitor/pull/72?email_source=notifications&email_token=AB72DNP3K7WF5AL473VSM6LQL6KP5A5CNFSM4I2QNNRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7263DA#issuecomment-536210828, or mute the thread https://github.com/notifications/unsubscribe-auth/AB72DNN3VU7BNCVJWRCGL6TQL6KP5ANCNFSM4I2QNNRA .

vfarcic commented 5 years ago

Having it on a branch will still be complicated to review and ensure that everything works correctly. Could you break it into smaller chunks that are easier to digest? As it is now, there are 103 files in this PR. I'm not even sure what most of them are.