docker-flow / docker-flow-proxy

Docker Flow Proxy
https://docker-flow.github.io/docker-flow-proxy/
MIT License
317 stars 189 forks source link

Manifest list broken for dfp #101

Closed RaymondMouthaan closed 5 years ago

RaymondMouthaan commented 5 years ago

Hello @vfarcic,

Just found out that the manifest list is broken on the latest build of dfp. The listener manifest still works.

Please consider the manifest inspect below.

docker manifest inspect dockerflow/docker-flow-proxy:latest

Hope this gets fixed soon, since i'm depending on it :)

Thanks in advance.

Ray

{
        "schemaVersion": 2,
        "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
        "config": {
                "mediaType": "application/vnd.docker.container.image.v1+json",
                "size": 11779,
                "digest": "sha256:d0ca9d66e7cb966e66f5a3bad4529a55e83d6795194e344725575c5399c6e657"
        },
        "layers": [
                {
                        "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
                        "size": 2206931,
                        "digest": "sha256:4fe2ade4980c2dda4fc95858ebb981489baec8c1e4bd282ab1c3560be8ff9bde"
                },
                {
                        "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
                        "size": 6963266,
                        "digest": "sha256:57919b60a28d8239c38964cd48132a9a1f8180c63eb9c5871bfc655ccde6b3c0"
                },
                {
                        "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
                        "size": 381,
                        "digest": "sha256:bcc7a0494c682eea1b5d90dfc2e7e9245c4e39d897165c2754a167b681b66009"
                },
                {
                        "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
                        "size": 17576,
                        "digest": "sha256:aa1673ddcba71201f0dc754e897489e7be6779a5d08afdcfab2bd48493add9ca"
                },
                {
                        "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
                        "size": 470,
                        "digest": "sha256:4287f1a3b9b8f6d7819e225e8b1d9646c1c211925b38419b51d1e0801953a96b"
                },
                {
                        "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
                        "size": 809,
                        "digest": "sha256:6420bb650ab39962749a2b9d45a3292f8b99beb7df20bf91c0fbd5e485addd00"
                },
                {
                        "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
                        "size": 501,
                        "digest": "sha256:87efc24cd3b20def468bda9da3d0c57c8dc975747831d18a87b9480353febe46"
                },
                {
                        "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
                        "size": 724,
                        "digest": "sha256:bab82d49db67c9d7aac06a1242953be494b98e5db8c7e5fdcd6d13332ea3b935"
                },
                {
                        "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
                        "size": 6498805,
                        "digest": "sha256:4a91fc281bab63740fd3186a67290cd1aad1f0d26c711e31ac668868b0977ab5"
                },
                {
                        "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
                        "size": 6499199,
                        "digest": "sha256:0451abe618898dd1f5d1d2049ae2211c39b07246eeb33f315974a28b13bb3ecb"
                }
        ]
}

docker manifest inspect dockerflow/docker-flow-proxy:19.08.09-17

{
        "schemaVersion": 2,
        "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
        "config": {
                "mediaType": "application/vnd.docker.container.image.v1+json",
                "size": 11779,
                "digest": "sha256:d0ca9d66e7cb966e66f5a3bad4529a55e83d6795194e344725575c5399c6e657"
        },
        "layers": [
                {
                        "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
                        "size": 2206931,
                        "digest": "sha256:4fe2ade4980c2dda4fc95858ebb981489baec8c1e4bd282ab1c3560be8ff9bde"
                },
                {
                        "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
                        "size": 6963266,
                        "digest": "sha256:57919b60a28d8239c38964cd48132a9a1f8180c63eb9c5871bfc655ccde6b3c0"
                },
                {
                        "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
                        "size": 381,
                        "digest": "sha256:bcc7a0494c682eea1b5d90dfc2e7e9245c4e39d897165c2754a167b681b66009"
                },
                {
                        "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
                        "size": 17576,
                        "digest": "sha256:aa1673ddcba71201f0dc754e897489e7be6779a5d08afdcfab2bd48493add9ca"
                },
                {
                        "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
                        "size": 470,
                        "digest": "sha256:4287f1a3b9b8f6d7819e225e8b1d9646c1c211925b38419b51d1e0801953a96b"
                },
                {
                        "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
                        "size": 809,
                        "digest": "sha256:6420bb650ab39962749a2b9d45a3292f8b99beb7df20bf91c0fbd5e485addd00"
                },
                {
                        "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
                        "size": 501,
                        "digest": "sha256:87efc24cd3b20def468bda9da3d0c57c8dc975747831d18a87b9480353febe46"
                },
                {
                        "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
                        "size": 724,
                        "digest": "sha256:bab82d49db67c9d7aac06a1242953be494b98e5db8c7e5fdcd6d13332ea3b935"
                },
                {
                        "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
                        "size": 6498805,
                        "digest": "sha256:4a91fc281bab63740fd3186a67290cd1aad1f0d26c711e31ac668868b0977ab5"
                },
                {
                        "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
                        "size": 6499199,
                        "digest": "sha256:0451abe618898dd1f5d1d2049ae2211c39b07246eeb33f315974a28b13bb3ecb"
                }
        ]
}
iMartzen commented 5 years ago

Would be great if it will be fixed. I am depending on it either :)

thomasjpfan commented 5 years ago

It looks like docker manifest is a experimental feature

May you specific what is broken or missing in our manifest? As an example, what does the working docker swarm listener manifest look like?

RaymondMouthaan commented 5 years ago

About a year ago I helped implementating multi archs support for dfp, but I am not sure what broke it two days back...

You should have a look at the Jenkins pipeline and it's logging. If you send me the the link I can have a look as well, I might find the cause of the issue.

thomasjpfan commented 5 years ago

I am not able to access the Jenkins pipeline. Hmm there was another PR merged a few days ago, it could be related to this.

vfarcic commented 5 years ago

Sorry about that... It should be OK now. Can you please try it out?

RaymondMouthaan commented 5 years ago

Thanks for the quick response! I can confirm that the manifest lists are fixed 👍 .

docker manifest inspect dockerflow/docker-flow-proxy:latest

{
   "schemaVersion": 2,
   "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
   "manifests": [
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 2406,
         "digest": "sha256:182a427b811854935cd5d10f2cfb3c999a22cdcc26e4efd076fef8552a8ee7b0",
         "platform": {
            "architecture": "amd64",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 2823,
         "digest": "sha256:266dd8d1cfd2b4b1923a1840aa9813a13e66263616b6789b022c1fc55afbda70",
         "platform": {
            "architecture": "arm",
            "os": "linux",
            "variant": "v7"
         }
      }
   ]
}

docker manifest inspect dockerflow/docker-flow-proxy:19.08.11-18

{
   "schemaVersion": 2,
   "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
   "manifests": [
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 2406,
         "digest": "sha256:182a427b811854935cd5d10f2cfb3c999a22cdcc26e4efd076fef8552a8ee7b0",
         "platform": {
            "architecture": "amd64",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 2823,
         "digest": "sha256:266dd8d1cfd2b4b1923a1840aa9813a13e66263616b6789b022c1fc55afbda70",
         "platform": {
            "architecture": "arm",
            "os": "linux",
            "variant": "v7"
         }
      }
   ]
}