docker-flow / docker-flow-proxy

Docker Flow Proxy
https://docker-flow.github.io/docker-flow-proxy/
MIT License
317 stars 189 forks source link

Need for redirectUnlessHttpsProto #67

Closed audunhalland closed 5 years ago

audunhalland commented 5 years ago

This feature has been previously requested, then implemented and since regressed.

Original feature request: https://github.com/vfarcic/docker-flow-proxy/issues/351 Implementation: https://github.com/vfarcic/docker-flow-proxy/pull/374 Caused a problem: #4 Regression: #5

To sum up the original feature request, there is a need to perform a redirect unless the X-Forwarded-Proto: https header is present. Apparently, solving it by applying inverse logic based on the current query parameter redirectWhenHttpProto is not sufficient, ref. #4 .

So I'm suggesting a new service query parameter redirectUnlessHttpsProto to fix exactly our problem, avoiding making any bad surprises for anyone else. I'd be happy to supply a PR if there's general agreement that this is the way to go.